[Fixed]We really must fix the CGB Audio + States bug

[Squall Leonhart]

We must find away to restore audio with the CGB state, like we do with the DMG and AGB states.

[spacy51]

I did some tests:

 

 

Pokemon - Crystal Version (USA, Europe) (Rev A).zip

and Pokemon - Gold Version (USA, Europe).zip

[Cartridge type: 10 (ROM+MBC3+TIMER+RAM+BATT)]

(Tested only on title screen)

No problems at all.

 

 

Alone in the Dark - The New Nightmare (USA) (En,Fr,Es).zip

[Cartridge type: 1b (ROM+MBC5+RAM+BATT)]

(Tested only in intro)

After save state was loaded, sound has only half the volume it had when saving.

When creating and loading a save state at this point, sound stays at half the volume

 

 

Legend of Zelda, The - Oracle of Ages (USA).zip

[Cartridge type: 1b (ROM+MBC5+RAM+BATT)]

(Tested only in intro)

After save state was loaded, there is no sound anymore.

 

 

Legend of Zelda, The - Link's Awakening DX (USA, Europe) (Rev B).zip

[Cartridge type: 1b (ROM+MBC5+RAM+BATT)]

(Tested only in intro)

After save state was loaded, there is no sound anymore.

 

 

Harvest Moon 3 GBC (USA).zip

[Cartridge type: 1b (ROM+MBC5+RAM+BATT)]

(Tested only on title screen)

Only half the valume on sound load.

 

 

Croc 2 (USA).zip

[Cartridge type: 19 (ROM+MBC5)]

(Tested only in intro)

After save state was loaded, sound turns up from muted to 100% in one second.

 

 

Croc (USA, Europe).zip

[Cartridge type: 19 (ROM+MBC5)]

(Tested only on title screen)

After save state was loaded, there is no sound anymore.

 

 

Kirby's Dream Land 2 (USA, Europe).zip

[Cartridge type: 03 (ROM+MBC1+RAM+BATT)]

(Tested only on title screen)

After save state was loaded, sound has only half the volume it had when saving.

When creating and loading a save state at this point, sound stays at half the volume

 

 

Currently, I have no idea wether this is one or more bugs.

[mudlord]

Nice to see your here blargg [img]<fileStore.core_Emoticons>/emoticons/smile.png[/img]/emoticons/smile@2x.png 2x" width="20" height="20" />.

 

Now that GB/CGB state saving works, I can put the code in. As I remember, I had implemented it (even properly reading older sound save states too).

 

Thanks for wanting to help, really appreciated [img]<fileStore.core_Emoticons>/emoticons/happy.png[/img]/emoticons/happy@2x.png 2x" width="20" height="20" />.

 

I sent you a email to your Gmail address regarding SVN.

[spacy51]

Thank you very much for all the work you have put in VBA-M and I'm deeply sorry for Squall offending you [img]<fileStore.core_Emoticons>/emoticons/sad.png[/img]/emoticons/sad@2x.png 2x" width="20" height="20" />

[Squall Leonhart]

I don't have the current source code yet, but if it's like it was when I put the sound code in several months ago, it has the GB/CGB sound state code completely removed. At that time, I was told that there was some kind of bug with GB/CGB state saving such that it didn't work at all. That meant there would be no way to test any GB/CGB audio state saving code at the time, so I left it out completely. Now that GB/CGB state saving works, I can put the code in. As I remember, I had implemented it (even properly reading older sound save states too).

 

Blargg, please read the pm on snes9x forum, and accept my deepest appologies, I may come across as having an attitude alot of the time, and while sometimes it is intended, other times its just how i am, and isn't at all intended on offending anyone.

[tkelly]

I see earlier posts on this subject claiming that this issue has been fixed, but I'm using the latest build (SVN945) and I lose all audio when reloading a save state for a GB game (GBA save states load audio fine). Haven't changed any settings from default.

[Squall Leonhart]

the issue is fixed, loading OLD states however will not be.

[tkelly]

That's just it - the states I'm loading from are not old. They're completely new off just-downloaded ROMs. In one instance I tried to load one less than ten seconds after creating it, and no sound.

[Squall Leonhart]

whats the game.

[tkelly]

One game where the sound never comes back:

 

TMNT - Fall of the Foot Clan

 

Another game where it DOES come back but only AFTER completing a level:

 

Batman

 

I can dig up some more examples if you need...